Recognize "(field as IDisposable)?.Dispose()" #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkelbu
approved these changes
May 28, 2024
There was a problem hiding this comment.
Looks good to me. I only have a single question, but I'm happy to merge it when you are.
As usual a nice and simple addition @manfred-brands
| typeIdentifierName.Identifier.Text.Equals("IDisposable", StringComparison.Ordinal)) | ||
| // considering cast to I(Async)Disposable, e.g. in case of explicit interface implementation of IDisposable.Dispose() | ||
| // or in case of 'as IDisposable' or 'as IAsyncDisposable' | ||
| // or in case of 'is IDisposable' or 'is IAsyncDisposable' |
There was a problem hiding this comment.
Mostly a comment - as I think the code below looks good for cast and as-pattern, but I don't think is is handled here (only in lines 481-486) or am I overlooking something?
There was a problem hiding this comment.
No you are right, I added the comment until my nunit tests proofed me wrong that it was done when checking if statement.
manfred-brands
force-pushed
the
issue743_Dispose
branch
from
7b99dcd to
054d693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #743
Also adds recognition of
System.IDisposablein addition toIDisposable