Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holoscan SDK Response-Time Analysis #600

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pschowitz
Copy link

Scripts and paper artifact for timing analysis of Holoscan applications.

@Unifiedhealthcare
Copy link

Dope

@tbirdso tbirdso requested a review from sohamm17 December 2, 2024 15:39
Copy link
Contributor

@sohamm17 sohamm17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pschowitz!
The content looks mostly good, but we need a few more details. Left comments and suggestions.

tutorials/hsdk_rt_analysis/README.md Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/README.md Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/README.md Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/README.md Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/README.md Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/README.md Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/README.md Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/artifact/README.md Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/artifact/README.md Show resolved Hide resolved
tutorials/hsdk_rt_analysis/artifact/README.md Show resolved Hide resolved
@sohamm17
Copy link
Contributor

sohamm17 commented Dec 3, 2024

@pschowitz Also, kindly sign off your commits.

Copy link
Contributor

@sohamm17 sohamm17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Philip,

Few more code changes are required.

tutorials/hsdk_rt_analysis/artifact/base.cpp Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/artifact/base.cpp Show resolved Hide resolved
tutorials/hsdk_rt_analysis/artifact/base.cpp Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/artifact/base.cpp Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/artifact/base.cpp Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/artifact/base.cpp Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/artifact/base.cpp Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/artifact/code/visualize.py Outdated Show resolved Hide resolved
tutorials/hsdk_rt_analysis/artifact/code/visualize.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants