Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support Persist Bookmarks #3033

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

xiantang
Copy link

@xiantang xiantang commented Dec 22, 2024

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'll give it a full review and test in the next few days.

Initial thoughts:

  • Should we be using vim.json.encode instead of the fn ?
  • Please don't move existing methods (constructor, toggle)
  • This should be an optional feature in nvim-tree-opts, disabled by default
  • This needs checking and safety
    • Use a pcall or similar to prevent an error being raised
    • Report failures to the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist Bookmarks
2 participants