set force close flag instead of close window directly #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerwang
pushed a commit
that referenced
this pull request
Dec 5, 2016
BUG=666715 Review-Url: https://codereview.chromium.org/2516603003 Cr-Commit-Position: refs/heads/master@{#433417} (cherry picked from commit 48c91fb) Review URL: https://codereview.chromium.org/2519273003 . Cr-Commit-Position: refs/branch-heads/2924@{#55} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
…ehavior Having the CHECK in stable channel won't give us anything new and it is unfortunately too easy to trigger it (switch profiles repeatedly). Therefore removing the CHECK. This effectively rolls back those 2 changes: https://codereview.chromium.org/2549833002 https://codereview.chromium.org/2562413003 The change will need to be merged in M-56. BUG=665093 Review-Url: https://codereview.chromium.org/2650853003 Cr-Commit-Position: refs/heads/master@{#445567} (cherry picked from commit 1fd4837) Review-Url: https://codereview.chromium.org/2649033005 . Cr-Commit-Position: refs/branch-heads/2987@{#55} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
This fix crash due race condition in multi-profile mode in case some window is created before shelf initialized. Easiest way to repo is on fresh machine first sign-in to public account, sign-out, sign-in to corp Google account. ARC++ OptIn window should pop-up on start. NOTRY=true NOPRESUBMIT=true [email protected] BUG=684860 TEST=Manually, no more crashes. Review-Url: https://codereview.chromium.org/2736993002 Cr-Commit-Position: refs/heads/master@{#455315} (cherry picked from commit a897192) Review-Url: https://codereview.chromium.org/2738773003 Cr-Commit-Position: refs/branch-heads/3029@{#55} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
BUG=711713 Review-Url: https://codereview.chromium.org/2825133002 Cr-Commit-Position: refs/heads/master@{#465388} (cherry picked from commit 3a7aacd) Review-Url: https://codereview.chromium.org/2830743002 . Cr-Commit-Position: refs/branch-heads/3071@{#55} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
Previously, only new intents going to the current active session would go through CustomTabsConnection.onHandledIntent(), which is not the intended behavior, as this is used to trigger preconnection to redirect endpoints. [email protected] (cherry picked from commit 67e17f3) Bug: 739165 Change-Id: Ie9da5dcf4e25f4d0ca2044cba20956a316f7a253 Reviewed-on: https://chromium-review.googlesource.com/581110 Commit-Queue: Benoit L <[email protected]> Reviewed-by: Yusuf Ozuysal <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#488952} Reviewed-on: https://chromium-review.googlesource.com/586551 Reviewed-by: Benoit L <[email protected]> Cr-Commit-Position: refs/branch-heads/3163@{#55} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
This CL reverts a previous CL here: https://chromium-review.googlesource.com/c/chromium/src/+/591913 The previous CL caused a regression on Mac. GL renderer has difficulties dealing with RPDQs converted from SolidColorDrawQuads, this CL will make mask layer produce solid quads. We need to keep it reverted before we fix the gl renderer bug. NOTRY=true [email protected] (cherry picked from commit 8d1900b) Bug: 760807 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I844d02886329acbbbebd98200f8d2f90681adb8a Reviewed-on: https://chromium-review.googlesource.com/653317 Commit-Queue: Xida Chen <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Reviewed-by: Xianda Sun <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#500036} Reviewed-on: https://chromium-review.googlesource.com/653803 Reviewed-by: Xida Chen <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{#55} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
Instead of asking all agents to keep track of whether they are currently tracing or not and bail out of StopAndFlush if they are not tracing, the coordinator only sends StopAndFlush to an agent if the agent has successfully started tracing. BUG=774728 Change-Id: I79801d5c66a454ee3bb1ea4c6729039e81c61a82 Reviewed-on: https://chromium-review.googlesource.com/721967 Commit-Queue: Ehsan Chiniforooshan <[email protected]> Reviewed-by: oysteine <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#509439}(cherry picked from commit 6588f9b) Reviewed-on: https://chromium-review.googlesource.com/726539 Reviewed-by: Ehsan Chiniforooshan <[email protected]> Cr-Commit-Position: refs/branch-heads/3239@{#55} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
[email protected] Change-Id: I6ed5ad1df7694f19265fb0ce2c1b8e4e2dc5068a Reviewed-on: https://chromium-review.googlesource.com/882881 Reviewed-by: [email protected] <[email protected]> Cr-Commit-Position: refs/branch-heads/3325@{#55} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
This seems to be undefined behavior and is caught by the ASAN bot. [email protected] (cherry picked from commit 62a2906) Bug: 816372 Change-Id: I16435111c860115bf288798b0c88ea9e37daf147 Reviewed-on: https://chromium-review.googlesource.com/948843 Reviewed-by: Mihai Sardarescu <[email protected]> Commit-Queue: David Roger <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#541061} Reviewed-on: https://chromium-review.googlesource.com/952965 Reviewed-by: David Roger <[email protected]> Cr-Commit-Position: refs/branch-heads/3359@{#55} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
Accept() can be called more than once on the same MenuController, via context menus; in this situation, it's important to clear the animation so that input events get handled after the animation completes. [email protected] (cherry picked from commit 37ab908) Bug: 833048 Change-Id: Id3ac92ce91e78b57f2120d4527e35e597ea03067 Reviewed-on: https://chromium-review.googlesource.com/1012876 Reviewed-by: Scott Violet <[email protected]> Commit-Queue: Elly Fong-Jones <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#551410} Reviewed-on: https://chromium-review.googlesource.com/1015547 Reviewed-by: Elly Fong-Jones <[email protected]> Cr-Commit-Position: refs/branch-heads/3396@{#55} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
[email protected] Change-Id: Id78aabd02ae7b139c3fe42edba2fb82d9c976a4b Reviewed-on: https://chromium-review.googlesource.com/1079769 Reviewed-by: [email protected] <[email protected]> Cr-Commit-Position: refs/branch-heads/3440@{#55} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
[email protected] Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3e5cb5cd8b314d47713e9c6e84000b853e584dd7 Reviewed-on: https://chromium-review.googlesource.com/1149071 Reviewed-by: Krishna Govind <[email protected]> Cr-Commit-Position: refs/branch-heads/3497@{#55} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
Implements AudioContextManager mojo interface that can be obtained from a frame so that audible playback from WebAudio can be recorded by the browser. Whenever audible playback starts or stops, a message is sent to the browser indicating such. Bug: 855069 Change-Id: Ib236a9506a2a6d9b53e95948eb5519145805a2cb Reviewed-on: https://chromium-review.googlesource.com/1114147 Reviewed-by: Mounir Lamouri <[email protected]> Reviewed-by: Ken Buchanan <[email protected]> Reviewed-by: Kentaro Hara <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Reviewed-by: Nasko Oskov <[email protected]> Reviewed-by: Hongchan Choi <[email protected]> Commit-Queue: Raymond Toy <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#587867}(cherry picked from commit e413650) Reviewed-on: https://chromium-review.googlesource.com/1207810 Reviewed-by: Raymond Toy <[email protected]> Cr-Commit-Position: refs/branch-heads/3538@{#55} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
This cl relands the following cl after excluding the added tests. https://chromium-review.googlesource.com/c/chromium/src/+/1278963 This gives the solution more time to bake on ToT without getting reverted due to flaky tests. Meanwhile I will work on the tests to deflake them. [email protected],[email protected] Bug: 884728, 249063 Change-Id: Icc1e32ffe493f85d0ee74b0aff37ccdf078d0e8f Reviewed-on: https://chromium-review.googlesource.com/c/1281687 Commit-Queue: Charlie Reis <[email protected]> Reviewed-by: Kevin McNee <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#599781}(cherry picked from commit abad218) Reviewed-on: https://chromium-review.googlesource.com/c/1284066 Reviewed-by: Sahel Sharify <[email protected]> Cr-Commit-Position: refs/branch-heads/3578@{#55} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
Bug: b/116166191 Test: Manual Test Change-Id: I5611a49d124f75ff535724224594e3f098ed31be Reviewed-on: https://chromium-review.googlesource.com/c/1355520 Reviewed-by: Xiyuan Xia <[email protected]> Reviewed-by: Xiaohui Chen <[email protected]> Commit-Queue: Yue Li <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#613649}(cherry picked from commit b027ce5) Reviewed-on: https://chromium-review.googlesource.com/c/1362478 Reviewed-by: Yue Li <[email protected]> Cr-Commit-Position: refs/branch-heads/3626@{#55} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
Adds a browser test that loads an extension, sends it a message, and receives a reply; all while BEST_EFFORT tasks are disabled. This is a regression test for http://crbug.com/177163#c112. Note that the test caught a bug in that BEST_EFFORT task priority was being used when the NetworkService was enabled (different code path than normal). This change fixes that as well. Bug: 177163,924416,925117 Change-Id: I9e4e1874e0f03d5be53224845a4f6fa42ffc68b3 Reviewed-on: https://chromium-review.googlesource.com/c/1427468 Reviewed-by: François Doray <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: Chris Mumford <[email protected]> Commit-Queue: François Doray <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#626544}(cherry picked from commit 60ea85d) Reviewed-on: https://chromium-review.googlesource.com/c/1444993 Reviewed-by: Yuri Wiitala <[email protected]> Cr-Commit-Position: refs/branch-heads/3683@{#55} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
Cherry-picked from: https://chromium-review.googlesource.com/c/chromium/src/+/1513077 BUG=926539 [email protected] Change-Id: I90ca898574e4c9efb6bdbe35aade2860d9763399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518910 Reviewed-by: Stefan Zager <[email protected]> Cr-Commit-Position: refs/branch-heads/3729@{#55} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial fix for nwjs/nw.js#4918