-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show buttons when entering fullscreen #62
Open
ghostoy
wants to merge
1
commit into
nwjs:nw19
Choose a base branch
from
ghostoy:issue-5651
base: nw19
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and hide them before restoring to normal. fixed nwjs/nw.js#5651
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
OOPIFs need independent scroll animation timelines and hosts, because they have separate compositors. Ultimately we need to associate a ScrollingCoordinator which each local frame root, but until that work is done this CL resolves some known scrolling problems in --site-per-process mode. BUG=675695 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2631853002 Cr-Commit-Position: refs/heads/master@{#444947} (cherry picked from commit 65c7df6) Review-Url: https://codereview.chromium.org/2654883002 . Cr-Commit-Position: refs/branch-heads/2987@{#62} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
This is because NSImage only started conforming to NSecureCoding in 10.10 BUG=696759 Review-Url: https://codereview.chromium.org/2728173003 Cr-Commit-Position: refs/heads/master@{#454916} (cherry picked from commit 52f904d) Review-Url: https://codereview.chromium.org/2736223002 . Cr-Commit-Position: refs/branch-heads/3029@{#62} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
I only saw this crash once, and can't reproduce, but better safe than sorry. BUG=712823 Review-Url: https://codereview.chromium.org/2830463002 Cr-Commit-Position: refs/heads/master@{#465702} (cherry picked from commit 3eb6c9f) Review-Url: https://codereview.chromium.org/2826213002 . Cr-Commit-Position: refs/branch-heads/3071@{#62} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
This will allow filtering results for the sign-in process isolation trial to users that have actually browsed to accounts.google.com. [email protected] (cherry picked from commit 95e8906) Bug: 739418 Change-Id: I31c9b36614cbcf1440c692d29450a851a2e29aa3 Reviewed-on: https://chromium-review.googlesource.com/579629 Commit-Queue: Alex Moshchuk <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Reviewed-by: Lukasz Anforowicz <[email protected]> Reviewed-by: Steven Holte <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#488532} Reviewed-on: https://chromium-review.googlesource.com/586075 Reviewed-by: Alex Moshchuk <[email protected]> Cr-Commit-Position: refs/branch-heads/3163@{#62} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
[email protected] (cherry picked from commit e8e90c2) Bug: 762033 Change-Id: I1f9bb01d495ff7b437fbc1e44c53172dffe997a4 Reviewed-on: https://chromium-review.googlesource.com/649531 Reviewed-by: Bernhard Bauer <[email protected]> Commit-Queue: Peter Conn <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#499639} Reviewed-on: https://chromium-review.googlesource.com/654661 Reviewed-by: Peter Conn <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{#62} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
…checkbox. When user hits Enter on focused "Learn More" link of the EULA screen, adjacent checkbox was involuntary triggered. This CL fixed it. [email protected] (cherry picked from commit ddacd55) Bug: 771095 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I500ab0c41934c124a6ee1fa03a1ea7f62faf5485 Reviewed-on: https://chromium-review.googlesource.com/721892 Reviewed-by: Wenzhao (Colin) Zang <[email protected]> Commit-Queue: Alexander Alekseev <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#509454} Reviewed-on: https://chromium-review.googlesource.com/727661 Reviewed-by: Alexander Alekseev <[email protected]> Cr-Commit-Position: refs/branch-heads/3239@{#62} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
[email protected] (cherry picked from commit 96593ad) Bug: 804621 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If2d7c632d79b35647858a792fcaa721ae09ce710 Reviewed-on: https://chromium-review.googlesource.com/879290 Commit-Queue: Justin Cohen <[email protected]> Commit-Queue: Peter Lee <[email protected]> Reviewed-by: Peter Lee <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#531131} Reviewed-on: https://chromium-review.googlesource.com/884003 Reviewed-by: Justin Cohen <[email protected]> Cr-Commit-Position: refs/branch-heads/3325@{#62} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
This cl adds two user actions to Keyboard Shortcut Viewer (KSV): 1. The times user creates a new window of Keyboard Shortcut Viewer. 2. The times user enters search mode in Keyboard Shortcut Viewer. [email protected],[email protected] Bug: 768932 Test: can see the counts in chrome://user-actions. Change-Id: Id04f20c755def88f6f360d3c66ac1417180d5a94 Reviewed-on: https://chromium-review.googlesource.com/938381 Reviewed-by: Ahmed Fakhry <[email protected]> Reviewed-by: Steven Holte <[email protected]> Commit-Queue: Tao Wu <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#540300}(cherry picked from commit fdbb173) Reviewed-on: https://chromium-review.googlesource.com/953029 Reviewed-by: Tao Wu <[email protected]> Cr-Commit-Position: refs/branch-heads/3359@{#62} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
Add an item in settings to turn on/off contextual suggestions. [email protected] Bug: 822953 Change-Id: I9533b6afcc21c23ee580e8d7008b6dc3ca1e74d3 Reviewed-on: https://chromium-review.googlesource.com/1006232 Commit-Queue: Becky Zhou <[email protected]> Reviewed-by: Theresa <[email protected]> Reviewed-by: Matthew Jones <[email protected]> Reviewed-by: Bernhard Bauer <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#550465}(cherry picked from commit 5ea1b5b) Reviewed-on: https://chromium-review.googlesource.com/1015725 Reviewed-by: Becky Zhou <[email protected]> Cr-Commit-Position: refs/branch-heads/3396@{#62} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
[email protected] (cherry picked from commit 5b8466d) Bug: 845961 Change-Id: Ifc9609058cd7cbd268785db46534e3ed09da6ce3 Reviewed-on: https://chromium-review.googlesource.com/1071510 Commit-Queue: Andy Paicu <[email protected]> Reviewed-by: Mike West <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#561834} Reviewed-on: https://chromium-review.googlesource.com/1080929 Reviewed-by: Andrew Whalley <[email protected]> Cr-Commit-Position: refs/branch-heads/3440@{#62} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
…uashing layer. Previously, in such situations we failed to mark the layer as needing layer requirements update, which already has code to issue an invalidation on the new backing of the content now that it lost squashing. Bug: 865415 [email protected] (cherry picked from commit afd0623) Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I807bf1426e45ce71ed42024512e9c77481f018cc Reviewed-on: https://chromium-review.googlesource.com/1145896 Commit-Queue: Chris Harrelson <[email protected]> Reviewed-by: Tien-Ren Chen <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#577404} Reviewed-on: https://chromium-review.googlesource.com/1149615 Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/branch-heads/3497@{#62} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
Nokia devices crash when trying to set to set the status bar color in bookmarks, history, and downloads. Disable status bar theming for now. BUG=880694 Change-Id: I48ae7ec0d7aa5059d70eb5a99b23e84d8263dcd0 Reviewed-on: https://chromium-review.googlesource.com/1207310 Reviewed-by: Matthew Jones <[email protected]> Commit-Queue: Theresa <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#588944}(cherry picked from commit 050fc9e) Reviewed-on: https://chromium-review.googlesource.com/1208351 Reviewed-by: Theresa <[email protected]> Cr-Commit-Position: refs/branch-heads/3538@{#62} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
If the brand code persisted in local prefs is empty, reinitialize to correct. Bug: 846033, 893451 Change-Id: I49cc299374d8530d3a46aee93cb7cb2518ff1dee Reviewed-on: https://chromium-review.googlesource.com/c/1272447 Reviewed-by: Xiyuan Xia <[email protected]> Reviewed-by: Wenzhao (Colin) Zang <[email protected]> Commit-Queue: Roger Tawa <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#599645}(cherry picked from commit 5d80e30) Reviewed-on: https://chromium-review.googlesource.com/c/1284532 Reviewed-by: Roger Tawa <[email protected]> Cr-Commit-Position: refs/branch-heads/3578@{#62} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
This change adds a new UMA Histogram that logs the referrer of a navigation to the manage passwords page. Logging is added in both native and Web UI. [email protected] (cherry picked from commit 08d6267) Bug: 904821 Change-Id: I727b0ace112f407121868d79181f523efecab511 Reviewed-on: https://chromium-review.googlesource.com/c/1355604 Commit-Queue: Jan Wilken Dörrie <[email protected]> Reviewed-by: Vasilii Sukhanov <[email protected]> Reviewed-by: Steven Bennetts <[email protected]> Reviewed-by: Demetrios Papadopoulos <[email protected]> Reviewed-by: Ilya Sherman <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#613150} Reviewed-on: https://chromium-review.googlesource.com/c/1361706 Reviewed-by: Jan Wilken Dörrie <[email protected]> Cr-Commit-Position: refs/branch-heads/3626@{#62} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
[email protected] Change-Id: Ie0b68555565c93350892c66b1b76840af254a497 Reviewed-on: https://chromium-review.googlesource.com/c/1445399 Reviewed-by: Krishna Govind <[email protected]> Cr-Commit-Position: refs/branch-heads/3683@{#62} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
BUG=925126 (cherry picked from commit 02d5848947400d769890ab3bfdf8eb66cd731c4e) Change-Id: I7e0f676f4e9e332945d70bedcbcb6f84665a3c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475881 Reviewed-by: Tommy Nyquist <[email protected]> Reviewed-by: Ilya Sherman <[email protected]> Reviewed-by: Ted Choc <[email protected]> Reviewed-by: Theresa <[email protected]> Reviewed-by: Tibor Goldschwendt <[email protected]> Commit-Queue: Yusuf Ozuysal <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#639609} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519092 Reviewed-by: Yusuf Ozuysal <[email protected]> Cr-Commit-Position: refs/branch-heads/3729@{#62} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
This reverts commit c0b9245. Reason for revert: breaks build, bug 941226 Original change's description: > Move tab_list_ui/ code into its own DFM > > BUG=925126 > > (cherry picked from commit 02d5848947400d769890ab3bfdf8eb66cd731c4e) > > Change-Id: I7e0f676f4e9e332945d70bedcbcb6f84665a3c80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475881 > Reviewed-by: Tommy Nyquist <[email protected]> > Reviewed-by: Ilya Sherman <[email protected]> > Reviewed-by: Ted Choc <[email protected]> > Reviewed-by: Theresa <[email protected]> > Reviewed-by: Tibor Goldschwendt <[email protected]> > Commit-Queue: Yusuf Ozuysal <[email protected]> > Cr-Original-Commit-Position: refs/heads/master@{#639609} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519092 > Reviewed-by: Yusuf Ozuysal <[email protected]> > Cr-Commit-Position: refs/branch-heads/3729@{#62} > Cr-Branched-From: d4a8972-refs/heads/master@{#638880} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] Change-Id: I473f8fca0da5bc3276d4ffbed466e8357d0a8bc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519451 Reviewed-by: Krishna Govind <[email protected]> Cr-Commit-Position: refs/branch-heads/3729@{#71} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and hide them before restoring to normal.
fixed nwjs/nw.js#5651