Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): support node native modules (gyp) #964

Merged
merged 23 commits into from
Oct 21, 2023
Merged

feat(build): support node native modules (gyp) #964

merged 23 commits into from
Oct 21, 2023

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Oct 18, 2023 •
edited
Loading

Fixes: #758

Description

  • Conditionally patch node/common.gypi to allow Python 3 usage (see which is the last node-gyp version which supported Python 2 and see which NW.js release version that corresponds to)
  • Test on Linux, MacOS and Windows platforms

@ayushmanchhabra ayushmanchhabra changed the title feat(build): support node native modules feat(build): support node native modules (gyp) Oct 20, 2023
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review October 21, 2023 00:00
@ayushmanchhabra ayushmanchhabra merged commit b55f200 into main Oct 21, 2023
9 checks passed
@ayushmanchhabra ayushmanchhabra deleted the dev-758 branch October 21, 2023 00:01
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node Native Addon (GYP)
1 participant
@ayushmanchhabra