-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream tunnel state over grpc #1924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 30 files reviewed, 1 unresolved discussion (waiting on @doums, @neacsu, @pronebird, @rokas-ambrazevicius, and @zaneschepke)
proto/nym/vpn.proto
line 1034 at r1 (raw file):
} enum ActionAfterDisconnect {
Can we scope these two? Or workaround it by prefixing the enum cases? These end up in the global namespace. You can check this by try e.g adding a INTERNAL = 4 to ActionAfterDisconnect, it will collide with INTERNAL = 10 from ErrorStateReason and fail to compile
33ee648
to
e30c690
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 30 files reviewed, 1 unresolved discussion (waiting on @doums, @neacsu, @octol, @rokas-ambrazevicius, and @zaneschepke)
proto/nym/vpn.proto
line 1034 at r1 (raw file):
Previously, octol (Jon Häggblad) wrote…
Can we scope these two? Or workaround it by prefixing the enum cases? These end up in the global namespace. You can check this by try e.g adding a INTERNAL = 4 to ActionAfterDisconnect, it will collide with INTERNAL = 10 from ErrorStateReason and fail to compile
Thanks for raising this. I have moved both of enums into TunnelState message.
Error error = 5; | ||
Offline offline = 6; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat API!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 30 files reviewed, 1 unresolved discussion (waiting on @neacsu, @pronebird, @rokas-ambrazevicius, and @zaneschepke)
e30c690
to
111665d
Compare
nym-vpn-lib
andnym-vpn-proto
intonym-vpn-lib-types
nym-vpn-lib-types
and provideFrom
conversions. It's really inconvenient that we have to duplicate structs but I guess we can't change how uniffi works.This change is