refactor(tauri): new tunnel state api #1967
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pronebird
reviewed
Jan 22, 2025
| #[derive(Default, Debug, Clone, Serialize, PartialEq, TS, strum::Display)] | ||
| #[ts(export)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub enum TunnelState { |
There was a problem hiding this comment.
Looking good. A bit unfortunate that you can't reuse the nym-vpn-lib-types and From conversions provided by #1950.
There was a problem hiding this comment.
Ja that's fine. having full control over my own proto types translation is the way. Simple.
No need an extra traslation layer.
Protobuf is there to enforce the type system cross boundary anyway.
doums
force-pushed
the
pierre/tunnel_state
branch
2 times, most recently
from
ca81be2 to
005107d
Compare
add watch tunnel state routine
rust some refactoring
doums
force-pushed
the
pierre/tunnel_state
branch
from
88f4a3e to
a8eb198
Compare
doums
force-pushed
the
pierre/tunnel_state
branch
from
be9ee77 to
38a0985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in short switch to the new tunnel state API WIP
This change is