Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add control messages to GatewayTransciver #5247

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Add control messages to GatewayTransciver #5247

merged 5 commits into from
Dec 16, 2024

Conversation

durch
Copy link
Contributor

@durch durch commented Dec 11, 2024 •
edited by mmsinclair
Loading

This change is Reviewable

@durch durch requested a review from jstuczyn December 11, 2024 14:12
@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 1:58pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 1:58pm

@durch durch added this to the Reeses milestone Dec 12, 2024
@durch durch marked this pull request as ready for review December 12, 2024 13:56
@durch durch requested a review from octol as a code owner December 12, 2024 13:56
@durch durch requested a review from simonwicky December 12, 2024 13:56
simonwicky
simonwicky requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@simonwicky simonwicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the session statistics part only. Can you make sure the unique users entry for that client gets deleted as well please?

nym-node/src/node/metrics/handler/client_sessions.rs Show resolved Hide resolved
@durch durch requested a review from simonwicky December 12, 2024 16:31
simonwicky
simonwicky reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@simonwicky simonwicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@durch durch merged commit 84d7004 into develop Dec 16, 2024
16 checks passed
@durch durch deleted the drazen/forget-me branch December 16, 2024 14:18
@tommyv1987
Copy link
Contributor

tommyv1987 commented Jan 13, 2025 •
edited
Loading

Testing Completion Report: Add Control Messages to Gateway Transceiver
Testing Completion Date: 13/01/2025

Testing Steps Performed:

Review and Testing: Forget Me Implementation

  • Validated the encryption and delivery of ForgetMe control messages to the gateway

Testing: MixTrafficController Integration

  • Verified that the MixTrafficController invokes ForgetMe logic correctly during shutdown
  • Tested behaviour for gateway transceiver failures while sending control messages

Testing: Gateway Storage Updates

  • Confirmed successful deletion of client data (e.g., inbox messages, bandwidth allocations) from persistent storage

Validation:

  • Test Passed
  • Issues Found: None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuczyn jstuczyn jstuczyn left review comments

@simonwicky simonwicky simonwicky approved these changes

@octol octol Awaiting requested review from octol octol is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Reeses
Development

Successfully merging this pull request may close these issues.
4 participants
@durch @tommyv1987 @jstuczyn @simonwicky