Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PATCH support to nym-http-api-client #5260

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

octol
Copy link
Contributor

@octol octol commented Dec 13, 2024

Add PATCH support to nym-http-api-client crate

The followup PR to deduplicate code is here #5267

This change is Reviewable

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 8:47am
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 8:47am

@octol octol force-pushed the jon/add-patch-to-http-api-client branch from 849d78e to 0145ba9 Compare December 16, 2024 08:47
@octol octol force-pushed the jon/add-patch-to-http-api-client branch from 0145ba9 to 7218465 Compare December 16, 2024 08:47
@octol octol marked this pull request as ready for review December 16, 2024 08:47
@octol octol added this to the Reeses milestone Dec 16, 2024
@octol octol requested a review from jstuczyn December 16, 2024 08:52
@octol octol merged commit 04c2045 into develop Dec 16, 2024
19 of 21 checks passed
@octol octol deleted the jon/add-patch-to-http-api-client branch December 16, 2024 11:28
@tommyv1987
Copy link
Contributor

Testing Completion Report: Add PATCH Support to HTTP API Client

Testing Completion Date: 08/01/2025

Validation:

  • PATCH support ensures parity with other HTTP methods (GET, POST, etc.) within the client library.

  • Test Passed

  • Issues Found (Please specify below)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants