Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close to credential storage #5283

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

octol
Copy link
Contributor

@octol octol commented Dec 17, 2024

Add close method to credential storage


This change is Reviewable

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 11:10pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 11:10pm

@octol octol marked this pull request as ready for review December 18, 2024 11:32
@octol octol requested a review from jstuczyn December 18, 2024 11:32
@octol octol added this to the Reeses milestone Dec 18, 2024
@octol octol merged commit acd068e into release/2024.15-reeses Dec 18, 2024
18 of 21 checks passed
@octol octol deleted the jon/add-close-to-credential-store branch December 18, 2024 11:37
octol added a commit that referenced this pull request Dec 18, 2024
* Add close method to credential storage

* wip
octol added a commit that referenced this pull request Dec 18, 2024
* Add close method to credential storage

* wip
@tommyv1987
Copy link
Contributor

tommyv1987 commented Jan 8, 2025

Testing Completion Report: Add Close to Credential Store

Testing Completion Date: 08/01/2025


Testing Steps Performed:

  1. Review File: common/credential-storage/src/backends/sqlite.rs

    • Verified addition of close method for the SQLite backend
  2. Review File: common/credential-storage/src/ephemeral_storage.rs

    • Confirmed addition of close method for ephemeral storage with no action required
  3. Review File: common/credential-storage/src/persistent_storage/mod.rs

    • Ensured close method integration for persistent storage
  4. Review File: common/credential-storage/src/storage.rs

    • Verified updates to the Storage trait to include close and cleanup_expired methods

Validation:

  • Test Passed
  • Issues Found (Please specify below)

Attachments (if applicable):

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants