This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Exposed query id and HTTP TRACE #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch-ubi into REST/exposed-query_id # Conflicts: # src/main/java/org/opensearch/ubi/action/UserBehaviorInsightsActionFilter.java
…earch-ubi into REST/exposed-query_id # Conflicts: # src/main/java/org/opensearch/ubi/action/UserBehaviorInsightsActionFilter.java
epugh
reviewed
Mar 4, 2024
| http.cors.allow-credentials: true | ||
| # TODO: add REST headers required here | ||
| http.cors.allow-headers: X-Requested-With,X-Auth-Token,Content-Type,Content-Length,Authorization |
There was a problem hiding this comment.
This docker compose is only for building and testing this plugin, so we should only added things that it requires.
epugh
suggested changes
Mar 4, 2024
| @@ -106,10 +110,13 @@ public void onResponse(Response response) { | |||
| LOGGER.error("Unable to persist query.", ex); | |||
| } | |||
|
|
|||
| LOGGER.info("######### Setting and exposing query_id {}", queryId); | |||
There was a problem hiding this comment.
Follow along the other other patterns...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Access-Control-Expose-Headersheader to allowquery_idto get past CORS restrictions.Testing can be done with https://github.com/o19s/ubi_playground/blob/main/tools/stub/cors_test.html.
I'm also leaving in the HTTP
TRACEverb so that we can do testing without breaking anything else in the plugin.