Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add if_ready variants of receive_message and poll, when ReadReady trait is implemented for io #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trepidacious
Copy link

Fix #39

May help with #36 and #38

@trepidacious
Copy link
Author

Just realised there's alaready #35 doing a similar thing - I think that PR will require ReadReady for all connections, for me that led to tests not compiling but I may be missing something. This one adds the new features only if the connection supports ReadReady. On the other hand it might be neater to use the approach from #35 and just let the user access read_ready() to check before doing a receive, rather than building it into a new receive method?

Copy link
Owner

@obabec obabec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trepidacious
Copy link
Author

@obabec Ah great, thanks for reviewing - is there anything else I need to do to allow merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for receiving message only if data is ready
2 participants