Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up imports #1850

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Clean up imports #1850

wants to merge 9 commits into from

Conversation

sebastianduesing
Copy link
Contributor

This PR includes the following changes to clean up the OntoFox import files, in order to streamline my upcoming attempt to transition OBI from OntoFox to ROBOT imports:

  • Remove redundant subClassOf assertions, i.e., those that are true within the source ontology and thus don't need to be stated in the import file.
  • Remove instances of multiple import statements for the same IRI.
  • Sort all import statements and subclass assertions numerically by IRI. For subclass assertions, this goes by the IRI of the subject, e.g., the lines that assert CL_0000001 subClassOf CL_0000010 sort above the lines that assert CL_0000003 subClassOf CL_0000000
  • Add a comment labeling every IRI with its term label for every import statement & subclass assertion line that doesn't already have its term label in a comment.

This is purely a tidying-up of the import text files themselves; these changes are designed have no effect on what OBI is actually importing. Running make imports etc. on the cleaned-up files results in zero changes to the output OWL files. The only OWL files diffs that appear in this PR are the result of an import refresh I did to make it easier to test the previous statement, and those changes will no longer show up in the diff with master once #1849 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant