Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CL 15 June release #1630

Merged
merged 2 commits into from
Jun 16, 2022
Merged

CL 15 June release #1630

merged 2 commits into from
Jun 16, 2022

Conversation

matentzn
Copy link
Contributor

@shawntanzk review with care. Many changes on first glance.

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontologies are identical

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontologies are identical

@shawntanzk
Copy link
Contributor

general removal of namespace:cell (in .obo format) or in owl: <oboInOwl:hasOBONamespace rdf:datatype="http://www.w3.org/2001/XMLSchema#string">cell</oboInOwl:hasOBONamespace>|
I assume this is intentional?

This is wrong, not sure why it didnt get picked up by qc before making its way here. (It's my stuff so I will fix it next release >.<)
Screenshot 2022-06-15 at 21 21 57
This is the term
[Term]
id: CL:0000695
name: Cajal-Retzius cell
But I wouldn't let this stop a release - can be fixed later.
Same thing in
[Term]
id: CL:0002453
name: oligodendrocyte precursor cell

(I think there are a few in there, not sure where this change came about)
In general there is a whole lot of use of dce in new terms -> so I'm guessing CL hasn't enforced the check yet.
Solution would be mass fix + qc check I would think

Copy link
Contributor

@shawntanzk shawntanzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing that should hold up the release I think

@shawntanzk shawntanzk mentioned this pull request Jun 15, 2022
@anitacaron
Copy link
Contributor

general removal of namespace:cell (in .obo format) or in owl: <oboInOwl:hasOBONamespace rdf:datatype="http://www.w3.org/2001/XMLSchema#string">cell</oboInOwl:hasOBONamespace>|
I assume this is intentional?

Yes, I removed in this PR

In general there is a whole lot of use of dce in new terms

Maybe this is because of the default property in Protege?
No need to create another issue for this. I'm already working to fix this one

@shawntanzk shawntanzk merged commit faa4d98 into master Jun 16, 2022
@shawntanzk shawntanzk deleted the release-2022-06-15 branch June 16, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants