Remove the EQ of 'Decreased adipose tissue' #10912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Nico. There are two things: (1) never had adipose tissue and (2) used to have adipose tissue, but it disappeared. I will need to go back and look at the annotated diseases to see if this distinction was made and if so, how to best write the definitions. Would it be ok to remove the EQ and then to make an issue about revising the definitions? |
|
I agree, lets remove the EQ (this pull request). I made an issue for you: #10913 |
|
I have removed both definitions -- which were not accurate anyway. I will keep the issue open until I have time to redo the definitions, but will close this PR:. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously the definitions of 'Decreased adipose tissue' and 'Adipose tissue loss' lead to QC barfing.. While I do not thing this fully addresses the issue, I think this EQ was wrong anyways, using an ancient pattern using "has fewer parts of type" some "adipose tissue", while we now tend to say "decreased amount". So whatever else you think needs to be fixed, I believe this should be merged as well.