Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Thecap CV Generator #5216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xthecapx
Copy link

@xthecapx xthecapx commented Jan 22, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: Link to my plugin: https://github.com/xthecapx/cv-generator

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template
❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ']', ..."tor"
},
]
" is not valid JSON


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@xthecapx xthecapx changed the title Add plugin: Thecap CV Generato Add plugin: Thecap CV Generator Jan 22, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template
❌ You don't have a manifest.json at the root of your repo, or it could not be parsed.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template
❌ It seems like you made a typo in the repository field xthecapx/cv-generator/tree/main/apps/obsidian.
❌ You don't have a manifest.json at the root of your repo, or it could not be parsed.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template
❌ The authorUrl field in your manifest should not point to the Obsidian Website. If you don't have a website you can just point it to your GitHub profile.
❌ The fundingUrl field in your manifest should not point to the Obsidian Website, If you don't have a link were users can donate to you, you can just remove it from the manifest.
❌ Unable to find a release with the tag 1.0.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template
❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ']', ..."tor"
},
]
" is not valid JSON


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Add plugin: Thecap CV Generator
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@xthecapx xthecapx marked this pull request as draft January 22, 2025 22:58
@xthecapx xthecapx closed this Jan 22, 2025
@xthecapx xthecapx reopened this Jan 22, 2025
@xthecapx xthecapx marked this pull request as ready for review January 22, 2025 23:05
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove the main.js file from the repo and add it to your .gitignore. Compiled release files shouldn't get mixed with source code in your commits and should go to the releases files instead.

[1][2][3]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Changes requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants