Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obs-websocket-api copy with CMake target #454

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

tytan652
Copy link
Contributor

Description

Replace obs-websocket-api copy with CMake target

Motivation and Context

Avoid maintaining copies of obs-websocket-api where we can use the target.

How Has This Been Tested?

Builds on my machine

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 force-pushed the less_copy_more_target branch from 7654abc to 525689a Compare September 14, 2024 23:46
@WizardCM WizardCM added the Code Cleanup Non-breaking change which makes code smaller or more readable label Sep 21, 2024
@RytoEX RytoEX requested a review from PatTheMav October 15, 2024 21:16
@RytoEX RytoEX merged commit fc946f2 into obsproject:master Oct 17, 2024
1 check passed
@tytan652 tytan652 deleted the less_copy_more_target branch October 18, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants