Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ryan Foster <[email protected]>
  • Loading branch information
dsaedtler and RytoEX authored Jan 23, 2025
1 parent 3614283 commit 7a35445
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion libobs/obs-encoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,8 @@ static void maybe_set_up_gpu_rescale(struct obs_encoder *encoder)
bool create_mix = true;
struct obs_video_info ovi;
const struct video_output_info *info;
uint32_t width, height;
uint32_t width;
uint32_t height;
enum video_format format;
enum video_colorspace space;
enum video_range_type range;
Expand Down
6 changes: 3 additions & 3 deletions libobs/obs.h
Original file line number Diff line number Diff line change
Expand Up @@ -2247,16 +2247,16 @@ EXPORT size_t obs_encoder_get_mixer_index(const obs_encoder_t *encoder);
* If the format is set to VIDEO_FORMAT_NONE, will revert to the default
* functionality of converting only when absolutely necessary.
*
* If GPU scaling is enabled conversion will happen on the GPU.
* If GPU scaling is enabled, conversion will happen on the GPU.
*/
EXPORT void obs_encoder_set_preferred_video_format(obs_encoder_t *encoder, enum video_format format);
EXPORT enum video_format obs_encoder_get_preferred_video_format(const obs_encoder_t *encoder);

/**
* Sets the preferred colorspace for an encoder, e.g. to simultaneous SDR and
* Sets the preferred colorspace for an encoder, e.g., to simultaneous SDR and
* HDR output.
*
* Only supported when GPU scaling is enabled
* Only supported when GPU scaling is enabled.
*/
EXPORT void obs_encoder_set_preferred_color_space(obs_encoder_t *encoder, enum video_colorspace colorspace);
EXPORT enum video_colorspace obs_encoder_get_preferred_color_space(const obs_encoder_t *encoder);
Expand Down

0 comments on commit 7a35445

Please sign in to comment.