Skip to content

Commit

Permalink
obs-webrtc: Allow non-CBR rate control with WHIP
Browse files Browse the repository at this point in the history
Nothing about WHIP requires CBR (and many things that use it use VBR),
and there's no specific upstream service to care about it (WHIP is a
protocol, not a service, despite being exposed as a "service" in OBS),
so let's stop forcing it to be CBR and allow the user to choose other
rate control methods.
  • Loading branch information
alinsavix authored and Lain-B committed Oct 28, 2023
1 parent 83e7cfb commit e6b3ae7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion plugins/obs-webrtc/whip-service.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ void WHIPService::ApplyEncoderSettings(obs_data_t *video_settings, obs_data_t *)
// For now, ensure maximum compatibility with webrtc peers
if (video_settings) {
obs_data_set_int(video_settings, "bf", 0);
obs_data_set_string(video_settings, "rate_control", "CBR");
obs_data_set_bool(video_settings, "repeat_headers", true);
}
}
Expand Down

0 comments on commit e6b3ae7

Please sign in to comment.