UI,libobs,obs-outputs: Remove HAVE_OBSCONFIG_H ifdefs #11472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gxalpha
added
the
Code Cleanup
|
I'm sorry that there is no module name |
WizardCM
reviewed
Nov 9, 2024
gxalpha
force-pushed
the
remove-have_obsconfig_h-ifdef
branch
from
43dc79e to
9d21189
Compare
|
Done. |
gxalpha
force-pushed
the
remove-have_obsconfig_h-ifdef
branch
from
9d21189 to
95b3d51
Compare
gxalpha
changed the title
With the removal of all legacy code paths, obsconfig.h always exists and the compile definition always gets set. As such, it's no longer necessary to check for it. As removing the definition itself could be seen as a breaking change, this simply adds a comment to it to, marking it for removal in the next major version.
gxalpha
force-pushed
the
remove-have_obsconfig_h-ifdef
branch
from
95b3d51 to
b810d3f
Compare
PatTheMav
reviewed
Jan 17, 2025
| @@ -280,6 +280,7 @@ target_include_directories( | |||
| PUBLIC "$<BUILD_INTERFACE:${CMAKE_BINARY_DIR}/config>" "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>" | |||
| ) | |||
|
|
|||
| # TODO: Remove for 32.0 | |||
| target_compile_definitions(libobs PUBLIC HAVE_OBSCONFIG_H) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
HAVE_OBSCONFIG_Hifdef-checks and marks the definition for removal in 32.0 (as removing it could be considered a breaking change, in case there are any third-party plugins checking for it).Motivation and Context
With the removal of all legacy code paths,
obsconfig.halways exists and theHAVE_OBSCONFIG_Hcompile definition always gets set. As such, it's no longer necessary to check for it.How Has This Been Tested?
Tested with CI that all builds still compile.
Tested with
git grepthat the definition line in cmake is now the only instance remaining ofHAVE_OBSCONFIG_H.Types of changes
Checklist: