(Do not look at this)(Seriously) Flathub publishing updates #9776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use more recent commits. Use a specific commit hash instead of v6.3 to include a fix for the order of arguments in some cases.
This is about to become a Flathub rule, let's pass that.
Validate the Flatpak manifest before building it; then, validate the build directory; and when publishing, validate the repository as well.
tytan652
reviewed
Oct 29, 2023
Comment on lines
+289
to
+292
| - name: Validate Flatpak manifest | ||
| run: | | ||
| : Validate Flatpak manifest | ||
| flatpak run --command=flatpak-builder-lint org.flatpak.Builder manifest ${{ github.workspace }}/build-aux/com.obsproject.Studio.json |
There was a problem hiding this comment.
I don't recommend doing this, the JSON schema provided by the linter is not up to date against the one in the flatpak/flatpak-builder repo.
There was a problem hiding this comment.
We should just follow the most recent one
There was a problem hiding this comment.
You also need to install the Builder Flatpak, like I did in my WIP commit tytan652@007bf85
Edit: I saw the change on the github action side.
WizardCM
added
Enhancement
This was referenced Nov 5, 2023
|
Superseded by #9814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to pass the build-log-url now, and validate our output with the flatpak-builder-linter tool. Let's do that.
Motivation and Context
Flathub is changing, and so should we.
How Has This Been Tested?
It hasn't.
Types of changes
Checklist: