Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade expo to version 50 #262

Merged
merged 4 commits into from
Jan 23, 2024
Merged

feat: upgrade expo to version 50 #262

merged 4 commits into from
Jan 23, 2024

Conversation

hamzamekk
Copy link
Contributor

@hamzamekk hamzamekk commented Jan 21, 2024

What does this do?

PR for Expo 50 Upgrade

  • Expo Version Update: Successfully upgraded our template to Expo 50. This brings us the latest features and improvements of the Expo framework.
  • Library Compatibility: Conducted a comprehensive update of most libraries to ensure full compatibility with Expo 50. Rigorous testing was done to confirm seamless integration.
  • Dynamic Modal Removal: The Dynamic Modal has been removed. In its place, we have enhanced the Bottom-Sheet component with specific, new properties to improve functionality and user experience.
  • TailwindCSS Downgrade for Async Issues: Downgraded TailwindCSS in our devDependencies. This change is aimed at fixing issues related to asynchronous plugins, specifically addressing the 'Use process(css).then(cb)' error.
  • Native Folder Updates with Kotlin for Android
  • start using expo-fonts

Why did you do this?

to have the latest features in our template

Who/what does this impact?

no one

How did you test this?

locally

Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for obytes-starter canceled.

Name Link
🔨 Latest commit b574968
🔍 Latest deploy log https://app.netlify.com/sites/obytes-starter/deploys/65ad8e5f0dfcc500087e84d5

@hamzamekk hamzamekk requested a review from yjose January 21, 2024 21:08
Copy link
Contributor

github-actions bot commented Jan 21, 2024

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 24%
23.99% (113/471) 16.11% (29/180) 5.58% (10/179)

😎 Tests Results

Tests Skipped Failures Errors Time
4 0 💤 0 ❌ 0 🔥 16.928s ⏱️
👀 Tests Details • (24%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files23.9916.115.5824.88 
src/ui/core/modal25.80026.66 
   index.tsx0000 

@yjose yjose changed the base branch from master to next January 22, 2024 13:52
@hamzamekk hamzamekk requested review from yjose and removed request for yjose January 22, 2024 22:56
import { useFonts } from 'expo-font';

//creating this hook to avoid having multiple fonts in root navigation
export const useFontsLoader = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this hook to load fint at runtime. We already loaded font statically

@yjose yjose self-requested a review January 23, 2024 10:45
@yjose yjose merged commit 437b76b into next Jan 23, 2024
1 check passed
@yjose yjose deleted the feat/upgradeExpo50 branch March 4, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants