Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use expo router #265

Merged
merged 7 commits into from
Jan 25, 2024
Merged

feat: use expo router #265

merged 7 commits into from
Jan 25, 2024

Conversation

ElenaBitire
Copy link
Collaborator

@ElenaBitire ElenaBitire commented Jan 25, 2024

What does this do?

Update the starter to use expo-router instead of navigation system.

Why did you do this?

Expo router provides a simple and declarative way to handle navigation.

Who/what does this impact?

Expo Router has the ability to statically type routes automatically. This ensures you can only link to valid routes and that you can't link to a route that doesn't exist.

How did you test this?

locally

@yjose yjose closed this Jan 25, 2024
@yjose yjose reopened this Jan 25, 2024
Copy link
Member

@yjose yjose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙌, just few remarks 👇

src/app/(app)/settings.tsx Outdated Show resolved Hide resolved
src/app/login.tsx Outdated Show resolved Hide resolved
@yjose yjose self-requested a review January 25, 2024 13:56
@yjose yjose merged commit a6fe72e into next Jan 25, 2024
1 check passed
@yjose yjose deleted the expo-router branch January 25, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants