Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unicode 16.0.0. #157

Merged
merged 13 commits into from
Oct 23, 2024
Merged

Add support for unicode 16.0.0. #157

merged 13 commits into from
Oct 23, 2024

Conversation

toots
Copy link
Member

@toots toots commented Sep 16, 2024

This PR adds support for unicode 16.0.0

Notes:

  • New non-binary properties were added to DerivedCoreProperties.txt. Those are not currently supported by the library and should be skipped for now.
  • Regression tests report code point 0x1171e missing in mn. This could be intentional.

There is quite a bit of noise due to some required module renaming to make the new old unicode ml file compile in the regression tests.

The only change otherwise is the addition, and use, of a to_list noop API to convert private Cset back into lists.

Otherwise, this is a fairly straight forward update.

@pmetzger
Copy link
Member

I haven't looked at Unicode 16; what are the non-binary properties for?

@toots
Copy link
Member Author

toots commented Sep 16, 2024

I haven't looked at Unicode 16; what are the non-binary properties for?

I think that this documents it: https://www.gnu.org/software/libunistring/manual/html_node/Indic-conjunct-break.html

src/generator/gen_unicode.ml Outdated Show resolved Hide resolved
examples/regressions.ml Outdated Show resolved Hide resolved
examples/dune Outdated Show resolved Hide resolved
src/generator/gen_unicode.ml Outdated Show resolved Hide resolved
examples/regressions.ml Outdated Show resolved Hide resolved
@toots
Copy link
Member Author

toots commented Oct 21, 2024

Ok I have cleaned up this PR and minimized the diff. I think that it is ready for merge now.

@pmetzger
Copy link
Member

There seem to be conflicts that would prevent a merge?

@toots
Copy link
Member Author

toots commented Oct 23, 2024

There seem to be conflicts that would prevent a merge?

You mean git conflicts?

Copy link
Contributor

@hhugo hhugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@toots toots merged commit da551b9 into master Oct 23, 2024
1 check passed
@toots
Copy link
Member Author

toots commented Oct 23, 2024

Thanks, just merged!

I think we should consider a release soon.

@toots toots deleted the unicode-16 branch October 23, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants