Fix printing of symbols of fixity #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-osborne
force-pushed
the
fix-printing-fixity-symbols
branch
2 times, most recently
from
af5b2fc to
f6f245a
Compare
n-osborne
force-pushed
the
fix-printing-fixity-symbols
branch
4 times, most recently
from
d19fafc to
42137c8
Compare
n-osborne
force-pushed
the
fix-printing-fixity-symbols
branch
from
42137c8 to
4629e02
Compare
Not updating tests as this commit breaks everything
This commit proposes support for partial and complete application of infix symbols.
This commit proposes support for partial and complete application of prefix symbols.
This commit proposes support for printing partial and complete application of mixfix symbols. Note that there is no support for mixfix symbols with an arity greater than the number of underscore + 1 as there are no such mixfix symbols defined in Gospel and there is no way at the moment for the user to defined new mixfix symbols.
n-osborne
force-pushed
the
fix-printing-fixity-symbols
branch
from
4629e02 to
0a8ab9e
Compare
|
Ready for review. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a fix of the way symbols with fixity are printed in
Tterm_printer.print_term.This is a first step towards a proprer pretty printer.
This also modifies how the fixity is encoded, proposing to store the information in a field of the identifiers with a sum type rather than in the name itself.