Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch selection of GLPK to Dune virtual libraries #24

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Jul 8, 2019

This is a continuation of the work in #22 to make the vendored GLPK completely separate from the forked MCCS. This takes advantage of the Dune virtual libraries introduced in version 1.7 of the language (the implementation details for MCCS mean that Dune 1.9.2 or later is required).

Various notes:

  • The shared and static variants are built by default - if you don't have GLPK installed, then src/glpk-static/dune and src/glpk-shared/dune must be blown away before the build (see mccs.opam and the temporary steps in appveyor.yml)
  • I have done some work previously on manually compiling glpk for Windows - at some point in the coming months I'll dust it off and push it so that AppVeyor can test all three builds too
  • I use the default_implementation field to mean that opam carries on using the internal solver by default - downstream builds such as Debian can in future alter src/solver/dune in opam to change mccs to mccs.shared.
  • The context_flags.ml and context_flags_all.ml should be merged and tidied up. The git diff appears to have got thoroughly confused by the renaming - they're basically unchanged!

@dra27 dra27 force-pushed the virtual branch 2 times, most recently from 05a9e93 to 4a348c7 Compare July 18, 2019 11:18
@Alessandro-Barbieri
Copy link

Any plan to continue this?

@kit-ty-kate kit-ty-kate marked this pull request as draft August 5, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants