Fix interpretation of glob patterns in .ocamlformat-ignore under Windows #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetiot
approved these changes
Dec 5, 2022
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
gpetiot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1773
ocaml-rehas a flag~match_backslashes:truewhich means that forward backslashes in the pattern will match both forward and backward backslashes in the matched filename. But it gets a bit tricky because backward slashes in the pattern will still act as normal backslashes (escaping the following character), so we need to make sure there are no backward slashes in the pattern before building the regexp.All in all, an ugly solution, but am not sure we can do much better with
ocaml-re's current API.