refactor: share exception with glob parser (#546)

ocaml · Oct 25, 2024 · 61409cd · 61409cd
1 parent 9d58581
commit 61409cd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/glob.ml b/lib/glob.ml
@@ -22,7 +22,7 @@
 
 module Re = Core
 
-exception Parse_error
+exception Parse_error = Parse_buffer.Parse_error
 
 type enclosed =
   | Char of char

diff --git a/lib/parse_buffer.ml b/lib/parse_buffer.ml
@@ -37,6 +37,7 @@ let accept_s t s' =
   let len = String.length s' in
   try
     for j = 0 to len - 1 do
+      (* CR-someday rgrinberg: stop relying on bound checks *)
       try if s'.[j] <> t.str.[t.pos + j] then raise_notrace Exit with
       | _ -> raise_notrace Exit
     done;