Fix calculation of remaining number of cache slots (prompt tokens not accounted) #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
commented
Dec 19, 2023
| for seq_id, tokens in self.allocated_decode_tokens.items(): | ||
| prompt_seq_id = get_prompt_sequence_id(seq_id.request_id) | ||
| prompt_tokens = self.allocated_prompt_tokens[prompt_seq_id] | ||
| total_tokens.append(prompt_tokens + tokens) |
There was a problem hiding this comment.
This code runs on a hot path and this naive loop incurs noticeable perf regression (5.89 -> 5.78 req / sec) for 13B. However, I suggest merging this as is and follow-up with a non-regressing solution later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sunggg @elvin-n
This happens when we run out of cache slots so we need to evict some requests. But we are not accounting for the prompt token counts in calculating the number of remaining free blocks, so we fail to detect the need for eviction when we need to.