Fix hanging on prompt counts > max model context len #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
commented
Nov 21, 2023
| @@ -85,7 +85,7 @@ async def generate(self, request: Request) -> AsyncIterator[RequestOutput]: | |||
| if output.is_finished: | |||
| return | |||
| except asyncio.CancelledError: | |||
| asyncio.to_thread(self.engine.cancel, request.request_id) | |||
| await asyncio.to_thread(self.engine.cancel, request.request_id) | |||
There was a problem hiding this comment.
@jroesch The bug fix is included here
masahi
commented
Nov 21, 2023
| @@ -58,7 +58,7 @@ def __init__( | |||
| self.cache_manager = model_module.cache_manager | |||
| self.tokenizer = model_module.tokenizer | |||
| self.model_artifact_config = model_module.model_artifact_config | |||
|
|
|||
| self.max_context_length = self.model_artifact_config.max_context_length | |||
There was a problem hiding this comment.
@sunggg I'm assuming that max_context_length is always available in the artifact. Let me know if it is not the case.
There was a problem hiding this comment.
Correct. It is safe to assume so at least for the models of our current interests.
masahi
added a commit
that referenced
this pull request
Nov 21, 2023
* fix cancelled request not awaited * fix working * compare against max_context_len --------- Co-authored-by: Masahiro Masuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.