Stop token follow up for staging engine. Properly report stop reason #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
changed the title
masahi
commented
Nov 22, 2023
| with self.queue_lock: | ||
| state = self._get_request_state(request_id) | ||
| if state: | ||
| del state |
There was a problem hiding this comment.
Not sure if we need to requests.append(state) here like in the original code. The original code has two append in cancel but they seem to be appending the same state. cc @yelite
There was a problem hiding this comment.
Never mind, I realized that self.queue and current_batch are disjoint. Sent a hot fix to #79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #72
@sunggg