Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add appchain agent message delivery #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kb1ns
Copy link

@kb1ns kb1ns commented Sep 19, 2022

No description provided.

@kb1ns kb1ns requested a review from hsxyl as a code owner September 19, 2022 19:34
@riversyang
Copy link
Member

riversyang commented Sep 21, 2022

Actually, I don't understand the intention of an account to sign a message for another account. I assume you want to operate the scenario like interchain account. In that case, the param sender_id_in_near of function deliver_appchain_agent_message should be removed, and you can use env::predecessor_account_id() as sender_id_in_near in corresponding AppchainNotification.

Even if it is the case I just mentioned, I still confused about the intention of this AppchainNotification. As the appchain anchor contract is a protocol level implementation of Octopus cross-chain bridge, I don't think we should add a type of Trojan horse message to our cross-chain message design. The bridge do not understand the intention of the new AppchainNotification, so it can not be handled/recovered properly if something goes wrong.

Furthermore, the appchain anchor contract can not work alone, it also needs a specific pallet in Octopus Appchain template to support the new AppchainNotification. Is there a pr on substrate side which can help us to understand the intention of appchain agent message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants