-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anchor position validity #779
base: main
Are you sure you want to change the base?
Conversation
View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..anchor-valid |
* main: upgrade yarn Bump the npm-minor-upgrades group across 1 directory with 9 updates Bump @11ty/eleventy-img in the npm-major-upgrades group Automated webmentions update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesnw Great article! I pushed some minor copy edits because that was quicker than submitting them individually as PR comments, but feel free to revert any of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesnw I think this is a great explainer! I started my review yesterday after standup and see some things have already changed. I will submit this as is and go back through it. I find the demos very helpful, and wonder if there is a reason (other than time) why we wouldn't include a Top Layer demo and anchor scope one.
exhaustive, and omits some cases with hidden content, fixed position anchors, | ||
and other less likely edge cases. | ||
|
||
We're also available for office hours to help work through your specific case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should include a link here too, but is it a different one that the reporting an item not on our list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the same one, but I think it makes sense to have it in both places.
@SondraE We could update this to point to an office hours page if one exists eventually.
@stacyk I added demos for anchor scope and top layer. I was avoiding top layer because I suspect there's an issue with the spec, so I elaborated on what is working a bit. |
* main: update yarn.lock Bump the npm-minor-upgrades group with 5 updates Automated webmentions update
Co-authored-by: Jonny Gerig Meyer <[email protected]>
Description
My goal for this article is to be a resource that can be used when someone's anchor isn't being found.
Related Issue(s)
#778
https://deploy-preview-779--oddleventy.netlify.app/2025/01/15/anchor-position-validity/
Questions for review: