-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] sales: update simplified pricelist settings #11709
base: saas-17.4
Are you sure you want to change the base?
Conversation
Hi @larm-odoo this PR is ready for peer review, when you have a chance. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dikd-odoo - super simple, easy update! Just a couple of minor suggestions, and one formatting correction. Approving because the formatting one is quick, and the others are totally unnecessary.
content/applications/sales/sales/products_prices/prices/pricing.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/pricing.rst
Outdated
Show resolved
Hide resolved
Add suggestions from LARM review Co-authored-by: larm-odoo <[email protected]>
3f07a35
to
f39b49a
Compare
Thank you for the suggestions, @larm-odoo! Hi @Felicious this PR is ready for final review, when you have a chance. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes look great to me, @dikd-odoo ! Grateful for the effort you’ve put into improving clarity and conciseness in this document. Approving now! 😊
That said, I need to adjust the point value of this PR from 3 points to 1 point. I’m sorry for the confusion, and I take partial responsibility—our current guidelines for task scoring could be clearer, and we're working on a document to better explain these specifications.
Here’s a quick summary of how tasks are scored:
- 3 points: A significant rework where ~50-80% of the document is revised.
- 2 points: Version-specific updates or improvements to a single section.
- 1 point: Tiny edits such rewriting a few sentences.
Your rewrite of lines 16–28 into the streamlined version at lines 16–18 is fantastic—clearer and more concise! However, since this PR focuses on rewording a few sentences rather than updating the entire section or addressing outdated UI comprehensively, it qualifies as a small cosmetic change worth 1 point.
To bring this PR to 2 points, you’d need to update the rest of the section (from the Pricelist configuration heading to the Price rules tab section), ensure all instructions are fully relevant for saas 17.4, refine the rest for clarity and conciseness, and replace outdated images.
If you'd like to make the changes to be 2 points, tag me again after you've made the updates, and I'll review it again. Let me know if you have any questions!
Updating Pricelists picture and documentation text for 17.4+, simplified Pricelists description in settings, removed 'Pricing Strategy Options' section. Also cleaning up language in documentation.
Task: https://www.odoo.com/odoo/my-tasks/4343498