Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sales: update simplified pricelist settings #11709

Open
wants to merge 1 commit into
base: saas-17.4
Choose a base branch
from

Conversation

dikd-odoo
Copy link
Contributor

Updating Pricelists picture and documentation text for 17.4+, simplified Pricelists description in settings, removed 'Pricing Strategy Options' section. Also cleaning up language in documentation.

Task: https://www.odoo.com/odoo/my-tasks/4343498

@robodoo
Copy link
Collaborator

robodoo commented Jan 7, 2025

Pull request status dashboard

@dikd-odoo dikd-odoo added the 3 label Jan 7, 2025
@dikd-odoo dikd-odoo changed the base branch from saas-17.4 to 17.0 January 7, 2025 16:29
@dikd-odoo dikd-odoo changed the base branch from 17.0 to saas-17.4 January 7, 2025 16:29
@C3POdoo C3POdoo requested a review from a team January 7, 2025 16:30
@dikd-odoo dikd-odoo self-assigned this Jan 7, 2025
@dikd-odoo dikd-odoo requested a review from larm-odoo January 7, 2025 17:00
@dikd-odoo
Copy link
Contributor Author

Hi @larm-odoo this PR is ready for peer review, when you have a chance. Thank you!

Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dikd-odoo - super simple, easy update! Just a couple of minor suggestions, and one formatting correction. Approving because the formatting one is quick, and the others are totally unnecessary.

Add suggestions from LARM review

Co-authored-by: larm-odoo <[email protected]>
@dikd-odoo dikd-odoo force-pushed the 17.4-sales-pricelists-dikd branch from 3f07a35 to f39b49a Compare January 8, 2025 22:06
@dikd-odoo
Copy link
Contributor Author

Thank you for the suggestions, @larm-odoo!

Hi @Felicious this PR is ready for final review, when you have a chance. Thank you!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes look great to me, @dikd-odoo ! Grateful for the effort you’ve put into improving clarity and conciseness in this document. Approving now! 😊

That said, I need to adjust the point value of this PR from 3 points to 1 point. I’m sorry for the confusion, and I take partial responsibility—our current guidelines for task scoring could be clearer, and we're working on a document to better explain these specifications.

Here’s a quick summary of how tasks are scored:

  • 3 points: A significant rework where ~50-80% of the document is revised.
  • 2 points: Version-specific updates or improvements to a single section.
  • 1 point: Tiny edits such rewriting a few sentences.

Your rewrite of lines 16–28 into the streamlined version at lines 16–18 is fantastic—clearer and more concise! However, since this PR focuses on rewording a few sentences rather than updating the entire section or addressing outdated UI comprehensively, it qualifies as a small cosmetic change worth 1 point.

To bring this PR to 2 points, you’d need to update the rest of the section (from the Pricelist configuration heading to the Price rules tab section), ensure all instructions are fully relevant for saas 17.4, refine the rest for clarity and conciseness, and replace outdated images.

If you'd like to make the changes to be 2 points, tag me again after you've made the updates, and I'll review it again. Let me know if you have any questions!

@Felicious Felicious added 1 and removed 3 labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants