[FIX] sheet view: DELETE_SHEET in initial revisions

If a revision contains a `UPDATE_CELL`, the sheet is added to the `sheetsWithDirtyViewports` set. But the sheet isn't when deleting the sheet. So if the initial revisions a sheet is updated then deleted, we'll try to update its viewport in the `finalize` and crash. closes #5362 Task: 4405573 X-original-commit: e2c9c48 Signed-off-by: Pierre Rousseau (pro) <[email protected]> Signed-off-by: Adrien Minne (adrm) <[email protected]>
odoo · Dec 17, 2024 · 1e87515 · 1e87515
1 parent b5034c5
commit 1e87515
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/src/plugins/ui_stateful/sheetview.ts b/src/plugins/ui_stateful/sheetview.ts
@@ -241,6 +241,7 @@ export class SheetViewPlugin extends UIPlugin {
         break;
       case "DELETE_SHEET":
         this.cleanViewports();
+        this.sheetsWithDirtyViewports.delete(cmd.sheetId);
         break;
       case "ACTIVATE_SHEET":
         this.sheetsWithDirtyViewports.add(cmd.sheetIdTo);

diff --git a/tests/sheet/sheetview_plugin.test.ts b/tests/sheet/sheetview_plugin.test.ts
@@ -3,12 +3,15 @@ import { CellComposerStore } from "../../src/components/composer/composer/cell_c
 import {
   DEFAULT_CELL_HEIGHT,
   DEFAULT_CELL_WIDTH,
+  DEFAULT_REVISION_ID,
+  MESSAGE_VERSION,
   getDefaultSheetViewSize,
 } from "../../src/constants";
 import { isDefined, numberToLetters, range, toXC, toZone, zoneToXc } from "../../src/helpers";
 import { Model } from "../../src/model";
 import { SheetViewPlugin } from "../../src/plugins/ui_stateful/sheetview";
 import { Zone } from "../../src/types";
+import { StateUpdateMessage } from "../../src/types/collaborative/transport_service";
 import {
   activateSheet,
   addColumns,
@@ -941,6 +944,25 @@ describe("Viewport of Simple sheet", () => {
       height: 4.5 * DEFAULT_CELL_HEIGHT,
     });
   });
+
+  test("Loading a model with initial revisions in sheet that is deleted doesn't crash", () => {
+    const initialMessages: StateUpdateMessage[] = [
+      {
+        type: "REMOTE_REVISION",
+        serverRevisionId: DEFAULT_REVISION_ID,
+        nextRevisionId: "1",
+        version: MESSAGE_VERSION,
+        clientId: "bob",
+        commands: [
+          { type: "CREATE_SHEET", position: 1, sheetId: "newSheetId" },
+          { type: "UPDATE_CELL", sheetId: "newSheetId", col: 0, row: 0, content: "1" },
+          { type: "DELETE_SHEET", sheetId: "newSheetId" },
+        ],
+      },
+    ];
+
+    expect(() => new Model({}, {}, initialMessages)).not.toThrow();
+  });
 });
 
 describe("Multi Panes viewport", () => {