[FIX] popover: wrong position on updated popover #5375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a popover has a change of props, we don't clean its style before computing its new height/width, leading to a wrong position sometimes. Task: 3814260
|
|
| el.style.top = ""; | ||
| el.style.left = ""; | ||
| el.style["max-height"] = ""; | ||
| el.style["max-width"] = ""; |
There was a problem hiding this comment.
you're resetting this here to have the correct getBoundingClientRect just below ? Is that right ?
|
Actually, I can't reproduce the issue neither in 17.0 nor master :/ |
robodoo
pushed a commit
that referenced
this pull request
Jan 23, 2025
If a popover has a change of props, we don't clean its style before computing its new height/width, leading to a wrong position sometimes. closes #5375 Task: 3814260 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a popover has a change of props, we don't clean its style before computing its new height/width, leading to a wrong position sometimes.
Task: 3814260
review checklist