Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] xlsx: support exporting array formulas #5403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rachico
Copy link
Contributor

@Rachico Rachico commented Jan 3, 2025

This commit improves the export of vectorized & array formulas, including those that spill across cells, ensuring better compatibility with other spreadsheet applications. The adopted approach is to treat all formulas as array formulas & to add an additional xml file that contains metadata about array formula properties. As a result, we improve the integrity & usability of our generated XLSX files.

Task: 4134347

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Jan 3, 2025

Pull request status dashboard

@Rachico Rachico force-pushed the master-export-array-formulas-mera branch 4 times, most recently from df51666 to 0d64d77 Compare January 8, 2025 12:44
This commit improves the export of vectorized & array formulas,
including those that spill across cells, ensuring better compatibility
with other spreadsheet applications. The adopted approach is to treat
all formulas as array formulas & to add an additional xml file that
contains metadata about array formula properties. As a result, we improve
the integrity & usability of our generated XLSX files.

Task: 4134347
@Rachico Rachico force-pushed the master-export-array-formulas-mera branch from 0d64d77 to 63d5ba8 Compare January 8, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants