[FIX] pivot: notify only with static formulas #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
When we update a pivot from it's side panel with a static pivot present in the viewport, we have the warning "Pivot updates only work with dynamic pivot tables". But the warning is also present if you have no static pivot anywhere, but that there is no dynamic pivot in the viewport (eg. you scolled a bit after opening the pivot side panel). The warning should only be displayed if you have a static pivot somewhere in the viewport and no dynamic pivot. Task: 4453844
LucasLefevre
force-pushed
the
18.0-static-pivot-warning-update-lul
branch
from
c552acb to
171a0c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When we update a pivot from it's side panel with a static pivot present in the viewport, we have the warning "Pivot updates only work with dynamic pivot tables". But the warning is also present if you have no static pivot anywhere, but that there is no dynamic pivot in the viewport (eg. you scolled a bit after opening the pivot side panel).
The warning should only be displayed if you have a static pivot somewhere in the viewport.
Task: 4453844
review checklist