[IMP] xlsx: support import/export of doughnut,pyramid & horizontal bar charts #5448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Rachico
force-pushed
the
master-xlsx-charts-mera
branch
5 times, most recently
from
2d3d4ab to
f4c84b0
Compare
…r charts This commit adds support for exporting & importing the charts mentioned above. Pyramid charts are not supported in Excel, therefore, we do a best effort by exporting them as horizontal bar charts. Task: 3978237
Rachico
force-pushed
the
master-xlsx-charts-mera
branch
from
f4c84b0 to
087e6ac
Compare
| @@ -180,7 +188,30 @@ export class PyramidChart extends AbstractChart { | |||
| } | |||
|
|
|||
| getDefinitionForExcel(): ExcelChartDefinition | undefined { | |||
| return undefined; | |||
| // Excel does not support pyramid charts, therefore we return a bar | |||
There was a problem hiding this comment.
I don't see where in this method it's said the new type is "bar"
Comment on lines
+87
to
+89
| plot = addDoughnutChart(chart.data, chartSheetIndex, data, { | ||
| holeSize: chart.data.isDoughnut ? 50 : 0, | ||
| }); |
There was a problem hiding this comment.
since we already give chart.data to addDoughnutChart, couldn't we do the holeSize thing inside addDoughnutChart ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for exporting & importing the charts mentioned above. Pyramid charts are not supported in Excel, therefore, we do a best effort by exporting them as horizontal bar charts.
Task: 3978237
review checklist