Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] charts: Account for correct locale when filtering empty datasets #5458

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 14, 2025

The filtering of empty datasets did not use the correct locale to evaluate the nature of a dataset value. Since it evaluates the actual stored data, it is based on the default locale (i.e. a dot as a decimal separator).

Task: 4465324

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5447

@robodoo
Copy link
Collaborator

robodoo commented Jan 14, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 14, 2025

@rrahir @pro-odoo cherrypicking of pull request #5447 failed.

stdout:

Auto-merging src/helpers/figures/charts/chart_ui_common.ts
CONFLICT (content): Merge conflict in src/helpers/figures/charts/chart_ui_common.ts
Auto-merging tests/figures/chart/chart_plugin.test.ts
CONFLICT (content): Merge conflict in tests/figures/chart/chart_plugin.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

The filtering of empty datasets did not use the correct locale to
evaluate the nature of a dataset value. Since it evaluates the actual
stored data, it is based on the default locale (i.e. a dot as a
decimal separator).

Task: 4465324
X-original-commit: d71d23f
@rrahir rrahir force-pushed the saas-18.1-18.0-fix-dataset-with-float-in-locale-rar-xFHc-fw branch from 8b96a10 to 4fe8a45 Compare January 14, 2025 10:37
@rrahir
Copy link
Collaborator

rrahir commented Jan 14, 2025

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 14, 2025
The filtering of empty datasets did not use the correct locale to
evaluate the nature of a dataset value. Since it evaluates the actual
stored data, it is based on the default locale (i.e. a dot as a
decimal separator).

closes #5458

Task: 4465324
X-original-commit: d71d23f
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants