karm-print: parametrize stock paper size with scale #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Print::PaperStock _paper attribute from Karm::Scene::Page is sized taking the scale parameter into account; however, this should not be the size of the paper when printing, that is, we should use the original paper size, not the scaled one. This commit couples the scaling logic to the printing classes, allowing the _paper attribute from Karm::Scene::Page to be sized back to its original size and thus the correct dimenions of the printing paper to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Print::PaperStock _paper attribute from Karm::Scene::Page is sized taking the scale parameter into account; however, this should not be the size of the paper when printing, that is, we should use the original paper size, not the scaled one.
This commit couples the scaling logic to the printing classes, allowing the _paper attribute from Karm::Scene::Page to be sized back to its original size and thus the correct dimenions of the printing paper to be used.