Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: TIA branch #355

Closed
wants to merge 1 commit into from
Closed

DNM: TIA branch #355

wants to merge 1 commit into from

Conversation

rbajollari
Copy link
Collaborator

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari requested a review from a team as a code owner February 15, 2024 15:42
@rbajollari rbajollari closed this Feb 15, 2024
@rbajollari rbajollari deleted the ryan/upgrade-sdk-50 branch February 15, 2024 15:45
Copy link

mergify bot commented Feb 15, 2024

⚠️ The sha of the head commit of this PR conflicts with #356. Mergify cannot evaluate rules on this PR. ⚠️

@rbajollari rbajollari restored the ryan/upgrade-sdk-50 branch February 15, 2024 15:47
@rbajollari rbajollari deleted the ryan/upgrade-sdk-50 branch February 15, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant