range: add oven timers and cook timers #843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and respective state sensors. when no timer is set, timer finish time is set to beginning of current day
ollo69
requested changes
Jan 5, 2025
Comment on lines
+165
to
+175
| @property | ||
| def oven_upper_cook_timer_time(self) -> datetime | None: | ||
| """Get the upper cook time finish time.""" | ||
| delta = self._get_time_delta( | ||
| "UpperCookTimeHour", "UpperCookTimeMin", "UpperCookTimeSec" | ||
| ) | ||
| return self._update_feature( | ||
| RangeFeatures.OVEN_UPPER_COOK_TIMER_TIME, | ||
| self._get_finish_time(delta), | ||
| False, | ||
| ) |
There was a problem hiding this comment.
We should find a way to check if the device provide this sensor (oven_upper_cook) and if not just return None, otherwise sensor for not existing cook zone will be created.
This is the same for all the other new properties.
There was a problem hiding this comment.
Yes. My oven only has upper, so the lower cook zone sensors are non-functional. I'll make the necessary changes for this.
Also, the stove top of my oven only reports whether any of the (five) burners are on, and it uses the front-left cooktop state to report it. So should cooktop state sensors also be modified (in a separate PR) in the same way you're suggesting here?
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds timestamp device sensors for upper/lower oven timers and cook times, and respective binary state sensors. When no timer is set, timer finish time is set to beginning of current day.