-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scalar chunking #365
Fix scalar chunking #365
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 85.42% 85.48% +0.05%
==========================================
Files 13 13
Lines 1537 1536 -1
==========================================
Hits 1313 1313
+ Misses 224 223 -1 ☔ View full report in Codecov by Sentry. |
Thanks for the contribution and the changelog. The change looks good and makes sense. The only question I have is whether anyone would consider this a breaking API change (and therefore require a major version bump) or if this is really just a bug fix? cc @joshmoore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. LGTM.
Previously, doing write_image(....storage_options={"chunks": 32})
would have resulted in chunks of e.g (sizeZ, sizeY, 32)
but this feature wasn't documented or have tests and the behaviour was different from zarr-python.
So, I think we could consider a change in this behaviour to be a bug-fix rather than a breaking API change, but happy to hear other opinions @joshmoore @sbesson ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d0c4e18
to
1927444
Compare
👍 changelog in the right place now. |
Fixes #364. I noticed there wasn't a changelog, so I added one, I hope that's okay? I think it's important to communicate bug fixes like this.