Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email #374

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Fix email #374

merged 5 commits into from
Nov 20, 2023

Conversation

pwalczysko
Copy link
Member

@pwalczysko pwalczysko commented Sep 6, 2023

Following the discussion last week about the demo email, this is an attempt to

  1. remove typos introduced by formatting of the text inside YAML
  2. remove links as they are possibly catched by spam filters, leave just one non-clickable link to walkthrough without https beginning
  3. simplify the text

cc @jburel @sbesson

Note: This is done on top of #373 in order not to downgrade by accident.

The new email body looks as follows:
Screenshot 2023-09-06 at 13 06 44

@pwalczysko
Copy link
Member Author

Deployed on demo successfully (thanks @sbesson ).

The new email looks like (suggestions welcome, cc @jburel - removed the links and simplified, of course have to leave the username and password though....)
Screenshot 2023-09-06 at 13 06 44

@pwalczysko
Copy link
Member Author

ditto #373 (comment)

@sbesson
Copy link
Member

sbesson commented Sep 14, 2023

Echoing my suspicion at #373 (comment):

  • the last successful build was on Sep, 6, 2023 11:50 GMT+1
  • the following build failed at Sep, 6, 2023 12:56 GMT+1 on the metrics tests.
  • omero-certificates 0.3.0 was deployed on PyPI at 12:43 GMT +1

@pwalczysko
Copy link
Member Author

Any objections to merge ? This has been already deployed and shown to work on demo server. If not merged, the danger is that we revert to the broken email from before by mistake cc @jburel @sbesson

@pwalczysko pwalczysko requested a review from sbesson November 20, 2023 11:40
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least nothing strikes me as a concern. If these changes are already applied, I agree that keeping playbooks out of date puts you guys at risk of inadvertently downgrading changes on production systems.

@pwalczysko pwalczysko merged commit 1df440c into ome:master Nov 20, 2023
10 checks passed
@pwalczysko pwalczysko deleted the fix-email branch November 20, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants