Fix exon annotation not showing #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinlu3
commented
Dec 19, 2024
Comment on lines
142
to
146
| if (m.group(1) != null && m.group(3) == null) { | ||
| // we only want to specify reference when it's one position ins/del | ||
| alteration.setRefResidues(m.group(1).toUpperCase()); | ||
| revisedProteinChange += alteration.getRefResidues(); | ||
| } |
There was a problem hiding this comment.
This change requires discussion. Is Y770_G772dup or 770_G772dup valid?
There was a problem hiding this comment.
According to hgvs nomenclature, the reference allele can be include for multi position change
bprize15
approved these changes
Jan 9, 2025
calvinlu3
force-pushed
the
fix/exon-info
branch
from
1664b8c to
8a7a01b
Compare
jfkonecn
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/oncokb/oncokb-pipeline/issues/630