feat(optimism): Reuse L1BlockInfoTx from Maili #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
reviewed
Jan 10, 2025
|
I believe the tests mostly cover the tx l1 cost functions which we should upstream to this pr since the cost functions are there. |
could also be done as 2 steps though to make it faster for dragan to review securely if he recognises his tests |
refcell
commented
Jan 11, 2025
|
This should be good to go now except for the git dep - i've added back the tests. |
emhane
reviewed
Jan 13, 2025
|
Opened into upstream revm here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kona as well as other libraries + applications use optimism types from maili.
maili-protocolexposes theL1BlockInfoTxtype that provides all the functionality used in revm's customL1BlockInfotype.This PR removes the redundant
L1BlockInfotype fromrevm, usingmaili_protocol::L1BlockInfoTxinstead.