-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ChatQnA] Switch to vLLM as default llm backend on Gaudi #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching from TGI to vLLM as the default LLM serving backend on Gaudi for the ChatQnA example to enhance the perf. Via benchmarking on Gaudi2 server with vLLM and TGI backend for LLM component for different ISL/OSL and various number of queries and concurrency, the geomean of measured LLMServe perf on a 7B model shows perf improvement of vLLM over TGI on several metrics including average total latency, average TPOT and throughput, while the geomean of average TTFT does not increase significantly. TGI is still offered as an option to deploy for LLM serving. Besides, vLLM LLM also replaces TGI LLM for other provided E2E ChatQnA pipelines including without-rerank pipeline and megaservice with guardrails. Implement opea-project#1213 Signed-off-by: Wang, Kai Lawrence <[email protected]>
Signed-off-by: Wang, Kai Lawrence <[email protected]>
Signed-off-by: Wang, Kai Lawrence <[email protected]>
Signed-off-by: Wang, Kai Lawrence <[email protected]>
Signed-off-by: Wang, Kai Lawrence <[email protected]>
Signed-off-by: Wang, Kai Lawrence <[email protected]>
Signed-off-by: Wang, Kai Lawrence <[email protected]>
Signed-off-by: Wang, Kai Lawrence <[email protected]>
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
for more information, see https://pre-commit.ci
Signed-off-by: Wang, Kai Lawrence <[email protected]>
…Examples into vllm-default-gaudi
…Examples into vllm-default-gaudi Signed-off-by: Wang, Kai Lawrence <[email protected]>
…Examples into vllm-default-gaudi
Signed-off-by: Wang, Kai Lawrence <[email protected]>
yao531441
approved these changes
Jan 17, 2025
XinyuYe-Intel
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switching from
TGI
tovLLM
as the default LLM serving backend on Gaudi for the ChatQnA example to enhance the perf. Via benchmarking on Gaudi2 server with vLLM and TGI backend for LLM component for different ISL/OSL and various number of queries and concurrency, the geomean of measured LLMServe perf on a 7B model shows perf improvement of vLLM over TGI on several metrics includingaverage total latency
,average TPOT
andthroughput
, while the geomean ofaverage TTFT
does not increase significantly. TGI is still offered as an option to deploy for LLM serving. Besides, vLLM LLM also replaces TGI LLM for other provided E2E ChatQnA pipelines includingwithout-rerank pipeline
andmegaservice with guardrails
. This PR also aligns the parameters of llm service in all chatqna test scripts with what in readme file.Issues
#1213
Type of change
Dependencies
n/a
Tests
TGI-Gaudi version: 2.0.6
vLLM-fork version: 0.6.3.dev910+g3c39626f
Benchmark and compare the LLMServe perf on Gaudi2 server with OOB-vLLM and Tuned-TGI backend via GenAIEval. Below table shows the referenced geomean perf ratio on 7B LLM with 4 sets of ISL/OSL, measured on different num_queries and concurrency, including 32/8, 128/32. Leveraging vLLM as LLM backend shows 1.14X-6.39X perf speedup on 3 metrics but not significant perf drop on avg TTFT.