Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): rate limit issue with lewagon/wait-on-check-action #10833

Merged
merged 2 commits into from
Mar 29, 2023
Merged

fix(CI): rate limit issue with lewagon/wait-on-check-action #10833

merged 2 commits into from
Mar 29, 2023

Conversation

akash-jain-10
Copy link
Collaborator

@akash-jain-10 akash-jain-10 commented Mar 29, 2023 •
edited
Loading

Describe your changes:

Ref - as per issue mentioned here, we will update out wait-interval to be 90 seconds between the Github API Requests for this github action step.

Here is the documentation for wait-interval - https://github.com/lewagon/wait-on-check-action#wait-interval-optional-default-10

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@akash-jain-10 akash-jain-10 requested a review from harshach as a code owner March 29, 2023 16:41
@akash-jain-10 akash-jain-10 self-assigned this Mar 29, 2023
ulixius9
ulixius9 previously approved these changes Mar 29, 2023
View reviewed changes
@github-actions github-actions bot added devops safe to test Add this label to run secure Github workflows on PRs labels Mar 29, 2023
@akash-jain-10 akash-jain-10 requested a review from ulixius9 March 29, 2023 17:02
@pmbrull pmbrull merged commit 2e985c6 into main Mar 29, 2023
@pmbrull pmbrull deleted the fix/ci-rate-limits branch March 29, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

@NiharDoshi99 NiharDoshi99 Awaiting requested review from NiharDoshi99

@dhruvinmaniar123 dhruvinmaniar123 Awaiting requested review from dhruvinmaniar123

@ulixius9 ulixius9 Awaiting requested review from ulixius9

Assignees

@akash-jain-10 akash-jain-10

Labels
devops safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akash-jain-10 @pmbrull @ulixius9